System-End/github-readme-stats
1
0
Fork 0
mirror of https://github.com/System-End/github-readme-stats.git synced 2026-04-19 16:38:23 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

refactor(stats card fetcher): improve could not fetch total commits error message (#3255)

Browse source
This commit is contained in:
Alexandr Garbuzov 2023-09-21 21:30:24 +03:00 • committed by GitHub
parent 12f84f89c8
commit 65c3300189
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 22 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
src/fetchers/stats-fetcher.js
View file

@ -180,7 +180,10 @@ const totalCommitsFetcher = async (username) => {
const totalCount = res.data.total_count;
if (!totalCount || isNaN(totalCount)) {
throw new Error("Could not fetch total commits.");
throw new CustomError(
"Could not fetch total commits.",
CustomError.GRAPHQL_ERROR,
);
}
return totalCount;
};

18
tests/api.test.js
View file

@ -304,4 +304,22 @@ describe("Test /api/", () => {
renderError("Something went wrong", "Language not found"),
);
});
it("should render error card when include_all_commits true and upstream API fails", async () => {
mock
.onGet("https://api.github.com/search/commits?q=author:anuraghazra")
.reply(200, { error: "Some test error message" });
const { req, res } = faker(
{ username: "anuraghazra", include_all_commits: true },
data_stats,
);
await api(req, res);
expect(res.setHeader).toBeCalledWith("Content-Type", "image/svg+xml");
expect(res.send).toBeCalledWith(
renderError("Could not fetch total commits.", "Please try again later"),
);
});
});