System-End/hackatime
1
0
Fork 0
mirror of https://github.com/System-End/hackatime.git synced 2026-04-19 21:05:15 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix crash when project name contains newline characters (#1096)

Browse source 
Project names with newlines (e.g. from misbehaving editor plugins) caused
ActionController::UrlGenerationError when loading /my/projects because Rails
route constraints reject newlines in URL parameters.

- Strip control characters from project names at heartbeat ingestion time
- Detect newlines in broken_project_name? to mark such projects as broken
- Skip URL generation for broken project names to prevent the crash

https://claude.ai/code/session_016CtSDw18BePckUBQ2teeuQ

Co-authored-by: Claude <noreply@anthropic.com>
This commit is contained in:
Mahad Kalam 2026-03-20 20:21:12 +00:00 • committed by GitHub
parent 10a30290e8
commit a9f3b613cd
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 11 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
app/controllers/api/hackatime/v1/hackatime_controller.rb
View file

@ -277,6 +277,8 @@ class Api::Hackatime::V1::HackatimeController < ApplicationController
source_type = :test_entry
end
heartbeat[:project] = heartbeat[:project]&.gsub(/[[:cntrl:]]/, "")&.strip
attrs = heartbeat.merge({
user_id: @user.id,
source_type: source_type,

16
app/controllers/my/project_repo_mappings_controller.rb
View file

@ -129,6 +129,8 @@ class My::ProjectRepoMappingsController < InertiaController
mapping = mappings_by_name[project_key]
display_name = project_key.presence || "Unknown"
broken = broken_project_name?(project_key, display_name)
url_safe = !broken && project_key.present?
{
id: project_card_id(project_key),
@ -139,12 +141,12 @@ class My::ProjectRepoMappingsController < InertiaController
duration_percent: 0,
repo_url: mapping&.repo_url,
repository: repository_payload(mapping&.repository, latest_user_commit_at_by_repo_id),
broken_name: broken_project_name?(project_key, display_name),
manage_enabled: current_user.github_uid.present? && project_key.present?,
edit_path: project_key.present? ? edit_my_project_repo_mapping_path(project_key) : nil,
update_path: project_key.present? ? my_project_repo_mapping_path(project_key) : nil,
archive_path: project_key.present? ? archive_my_project_repo_mapping_path(project_key) : nil,
unarchive_path: project_key.present? ? unarchive_my_project_repo_mapping_path(project_key) : nil
broken_name: broken,
manage_enabled: current_user.github_uid.present? && url_safe,
edit_path: url_safe ? edit_my_project_repo_mapping_path(project_key) : nil,
update_path: url_safe ? my_project_repo_mapping_path(project_key) : nil,
archive_path: url_safe ? archive_my_project_repo_mapping_path(project_key) : nil,
unarchive_path: url_safe ? unarchive_my_project_repo_mapping_path(project_key) : nil
}
end.sort_by { |project| -project[:duration_seconds] }
@ -177,7 +179,7 @@ class My::ProjectRepoMappingsController < InertiaController
key = project_key.to_s
name = display_name.to_s
key.blank? || name.downcase == "unknown" || key.match?(/<<.*>>/) || name.match?(/<<.*>>/)
key.blank? || name.downcase == "unknown" || key.match?(/<<.*>>/) || name.match?(/<<.*>>/) || key.match?(/[\r\n]/)
end
def repository_payload(repository, latest_user_commit_at_by_repo_id = {})